You are here 705137

[Fixed] Google Chrome launcher if jPortable installed 54603j

4 posts / 0 new
Last post
Karsonito
Offline
Last seen: 4 years 7 months ago
ed: 2012-07-11 17:37
[Fixed] Google Chrome launcher if jPortable installed

The problem appears if Chrome Portable started with url in path + jPortable installed. In that case Chrome starting without Java plugin because $EXECSTRING is incorrect:
"chrome.exe" ---data-dir="path\to\profile" --disk-cache-dir="path\to\Temp\GoogleChromePortable" -- http://goo.gl/ --extra-plugin-dir="path\to\CommonFiles\Java\bin\plugin2"

"-- http://goo.gl/" should follow last

I made a small patch:
--- GoogleChromePortable.nsi.bak 2012-02-17 17:36:40.000000000 +0200
+++ GoogleChromePortable.nsi.fix 2012-07-11 23:11:15.588451300 +0300
@@ -102,6 +102,7 @@
Var PROFILEDIRECTORY
Var SETTINGSDIRECTORY
Var ADDITIONALPARAMETERS
+Var URI
Var EXECSTRING
Var PROGRAMEXECUTABLE
!ifdef USEDEVSPLASH
@@ -653,10 +654,12 @@
Stry $1 ""
${EndIf}

+Stry $URI `$1 $0`
+
!ifdef CHROMESXSMODE
- Stry $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" --chrome-sxs ---data-dir="$PROFILEDIRECTORY" $1 $0`
+ Stry $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" --chrome-sxs ---data-dir="$PROFILEDIRECTORY"`
!else
- Stry $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" ---data-dir="$PROFILEDIRECTORY" $1 $0`
+ Stry $EXECSTRING `"$PROGRAMDIRECTORY\$PROGRAMEXECUTABLE" ---data-dir="$PROFILEDIRECTORY"`
!endif

${If} $UsePAMLanguage != "false"
@@ -701,6 +704,8 @@
Stry $EXECSTRING `$EXECSTRING $ADDITIONALPARAMETERS`
${EndIf}

+ Stry $EXECSTRING `$EXECSTRING $URI`
+
${If} $SECONDARYLAUNCH != "true"
${AndIf} $WAITFORPROGRAM == "true"
ExecWait $EXECSTRING

Please fix it in next release.

John T. Haller
John T. Haller's picture
Online
Last seen: 6 min 29 sec ago
DeveloperTranslator
ed: 2005-11-28 22:21
Fixed in Beta and Dev

I've fixed this in the 21.0.1180.41 Beta release. Could you please that it works as expected for you as well? And thank you for posting details of a fix! Smile

Update: It's fixed in the 22.0.1207.1 Dev release as well.

Sometimes, the impossible can become possible, if you're awesome!

Karsonito
Offline
Last seen: 4 years 7 months ago
ed: 2012-07-11 17:37
All works fine! Thanks! BTW,

All works fine! Thanks!

BTW, may I ask you for correct KillProc plugin for NSIS?

John T. Haller
John T. Haller's picture
Online
Last seen: 6 min 29 sec ago
DeveloperTranslator
ed: 2005-11-28 22:21
Fixed in Stable

This is now fixed in stable as well with the 21.0.1180.60 release.

Sometimes, the impossible can become possible, if you're awesome!

to post comments