You are here 705137

Portable App Development

Redundant $Bits variable removal 1i5s4w

5 posts / 0 new
to post comments
Last post
September 28, 2017 - 9:21pm
#1
Gord Caswell
Gord Caswell's picture
Offline
Last seen: 1 month 1 week ago
Developer
ed: 2008-07-24 18:46
Redundant $Bits variable removal

With the release of the portableapps.sitesunblocked.org Launcher version 2.1, the $Bits variable is set by PAL itself.
As such, setting this variable in Custom.nsh can be removed for the following applications, see applicable edits to the Custom.nsh files here:

  • 7-Zip **
  • AkelPad
  • Avidemux
  • Blender
  • Daphne
  • KVIrc
  • Krita
  • Listary
  • ProcessHacker
  • RapidCRCUnicode
  • RawTherapee **
  • TEncoder
  • UltraDefrag
  • VirtualDub
  • WaveShop
  • WinMTR

    • ** These applications require moving small pieces of code that were handled within the general code. See the github commit for details.

    This post has been stickied, with applications being removed from the list once updated.

Top
  • to post comments
September 29, 2017 - 11:24am
Bart.S
Offline
Last seen: 2 months 3 weeks ago
Developer
ed: 2008-07-23 07:56
x64.nsh

Why not '${If} ${RunningX64}' and drop $Bits?

Top
  • to post comments
September 29, 2017 - 4:05pm
demon.devin
demon.devin's picture
Offline
Last seen: 3 months 2 weeks ago
Developer
ed: 2007-08-02 09:04
Already in the codebase.

PAL uses the same means of detecting bit depth just like the x64.nsh header file. There's no need to include that extra file when the same thing is already being done.

Edit:
Here's an example of what you can use without the x64.nsh include file..

${If} $Bits == 32
 ; Blah blah blah
${ElseIf} $Bits == 64
 ; Blah blah blah
${Else}
 ; this should never execute and is unnecessary.. lol. 
${EndIf}

daemon.devin

Top
  • to post comments
September 30, 2017 - 7:25am
Bart.S
Offline
Last seen: 2 months 3 weeks ago
Developer
ed: 2008-07-23 07:56
Standard NSIS

x64.nsh is part of NSIS. Ustream code (functions, variables) is better than duplicate things in custom code.
Just my 2 cents.

Top
  • to post comments
September 30, 2017 - 8:45am
demon.devin
demon.devin's picture
Offline
Last seen: 3 months 2 weeks ago
Developer
ed: 2007-08-02 09:04
Okay.

Why would we want to include a file that uses the same code that PAL is already using?

This would just create more overhead, which can build up and in the long run is a bad thing.

daemon.devin

Top
  • to post comments
to post comments